Skip to content

Bazel: update rules_kotlin to 2.1.3 #19385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 29, 2025
Merged

Conversation

redsun82
Copy link
Contributor

No description provided.

@redsun82 redsun82 requested review from smowton and Copilot April 25, 2025 15:18
@redsun82 redsun82 requested a review from a team as a code owner April 25, 2025 15:18
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (6)
  • MODULE.bazel: Language not supported
  • misc/bazel/registry/modules/rules_kotlin/2.1.3-codeql.1/MODULE.bazel: Language not supported
  • misc/bazel/registry/modules/rules_kotlin/2.1.3-codeql.1/patches/codeql_add_language_version_option.patch: Language not supported
  • misc/bazel/registry/modules/rules_kotlin/2.1.3-codeql.1/patches/codeql_do_not_emit_jdeps.patch: Language not supported
  • misc/bazel/registry/modules/rules_kotlin/2.1.3-codeql.1/source.json: Language not supported
  • misc/bazel/registry/modules/rules_kotlin/metadata.json: Language not supported

@@ -21,6 +21,7 @@
"github:bazelbuild/rules_kotlin"
],
"versions": [
"2.1.3-codeql.1",
"2.0.0-codeql.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need the old one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, semmle-code does not use rules_kotlin, so we don't really need to keep the old one around. If semmle-code did use it we could keep it around until the next bump, but no need here.

@redsun82 redsun82 requested a review from igfoo April 28, 2025 08:22
@redsun82 redsun82 merged commit abbf753 into main Apr 29, 2025
24 checks passed
@redsun82 redsun82 deleted the redsun82/update-rules-kotlin branch April 29, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants