Skip to content

C#: Add cs/equality-on-floats to the Code Quality suite. #19396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 29, 2025
Merged

C#: Add cs/equality-on-floats to the Code Quality suite. #19396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2d6457e
C#: Set the precision of cs/equality-on-floats to high.
michaelnebel Apr 28, 2025
318bfc6
C#: Add cs/equality-on-floats to the code-quality suite.
michaelnebel Apr 28, 2025
8bc9656
C#: Update integration tests expected output.
michaelnebel Apr 28, 2025
f9d8be1
C#: Add change note.
michaelnebel Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions csharp/ql/integration-tests/posix/query-suite/csharp-code-quality.qls.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ ql/csharp/ql/src/Dead Code/DeadStoreOfLocal.ql
ql/csharp/ql/src/Likely Bugs/Collections/ContainerLengthCmpOffByOne.ql
ql/csharp/ql/src/Likely Bugs/Collections/ContainerSizeCmpZero.ql
ql/csharp/ql/src/Likely Bugs/DangerousNonShortCircuitLogic.ql
ql/csharp/ql/src/Likely Bugs/EqualityCheckOnFloats.ql
ql/csharp/ql/src/Likely Bugs/ReferenceEqualsOnValueTypes.ql
ql/csharp/ql/src/Likely Bugs/SelfAssignment.ql
ql/csharp/ql/src/Likely Bugs/UncheckedCastInEquals.ql
Expand Down
2 changes: 1 addition & 1 deletion csharp/ql/src/Likely Bugs/EqualityCheckOnFloats.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* computation does not follow the standard rules of algebra.
* @kind problem
* @problem.severity warning
* @precision medium
* @precision high
* @id cs/equality-on-floats
* @tags reliability
* correctness
Expand Down
4 changes: 4 additions & 0 deletions csharp/ql/src/change-notes/2025-04-28-equality-on-floats-precision.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: minorAnalysis
---
* Changed the precision of the `cs/equality-on-floats` query from medium to high.
1 change: 1 addition & 0 deletions csharp/ql/src/codeql-suites/csharp-code-quality.qls
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,4 @@
- cs/non-short-circuit
- cs/useless-assignment-to-local
- cs/invalid-string-formatting
- cs/equality-on-floats