C++: Add use-after-free FP tests #19397
Merged
+50
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request adds tests for known false positives related to use-after-free issues in C++ code.
- Removed an unused pointer variable in test9.
- Introduced new structures and a function (malloc_after_free) to simulate use-after-free scenarios consistent with reported false positives.
Files not reviewed (1)
- cpp/ql/test/query-tests/Security/CWE/CWE-416/semmle/tests/UseAfterFree/UseAfterFree.expected: Language not supported
| return; | ||
| } | ||
| use(s->i1.data); // GOOD [FALSE POSITIVE] | ||
|
|
There was a problem hiding this comment.
s->i2 is dereferenced without a prior check for null, which could lead to a segmentation fault if s->i2 is not properly initialized. Consider adding a null check for s->i2 before dereferencing.
Suggested change
| if (s->i2 == NULL) { | |
| return; | |
| } |
Copilot uses AI. Check for mistakes.
redsun82
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These derive from #19387. Note that these FPs are a known issue.