C#/Java/Rust: Change the tag for the model generator debugging queries. #19408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the tag for model generator debugging queries from "modelgenerator" to "debugmodelgenerator" across Rust, Java, and C# to support the DCA suites' requirements.
- Updated debug queries in CaptureSummaryModelsPath.ql and CaptureSummaryModelsPartialPath.ql files for Rust, Java, and C#.
- Ensured consistent tagging for better query differentiation during debugging.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rust/ql/src/utils/modelgenerator/debug/CaptureSummaryModelsPath.ql | Changed tag from modelgenerator to debugmodelgenerator |
| rust/ql/src/utils/modelgenerator/debug/CaptureSummaryModelsPartialPath.ql | Changed tag from modelgenerator to debugmodelgenerator |
| java/ql/src/utils/modelgenerator/debug/CaptureSummaryModelsPath.ql | Changed tag from modelgenerator to debugmodelgenerator |
| java/ql/src/utils/modelgenerator/debug/CaptureSummaryModelsPartialPath.ql | Changed tag from modelgenerator to debugmodelgenerator |
| csharp/ql/src/utils/modelgenerator/debug/CaptureSummaryModelsPath.ql | Changed tag from modelgenerator to debugmodelgenerator |
| csharp/ql/src/utils/modelgenerator/debug/CaptureSummaryModelsPartialPath.ql | Changed tag from modelgenerator to debugmodelgenerator |
hvitved
approved these changes
Apr 29, 2025
| @@ -5,7 +5,7 @@ | |||
| * @precision low | |||
| * @id csharp/utils/modelgenerator/summary-models-partial-path | |||
| * @severity info | |||
| * @tags modelgenerator | |||
| * @tags debugmodelgenerator | |||
There was a problem hiding this comment.
Alternatively, just remove the tags?
There was a problem hiding this comment.
Yeah, I also considered that - but decided to go with this - so I don't accidentally add the "missing" modelgenerator tag to these queries again in the future 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DCA suites are relying on the
modelgeneratortag, so we should tag the local debug queries differently.The failing Java integration test is unrelated.