Revert "Bazel: update rules_kotlin to 2.1.3"
#19414
Merged
+20
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the upgrade of rules_kotlin to version 2.1.3-codeql.1 due to build breakage, restoring the previously working version 2.0.0-codeql.1.
- Reverts the version string in metadata.json to "2.0.0-codeql.1".
- Removes the source.json and related files for rules_kotlin v2.1.3-codeql.1 and adds corresponding files for v2.0.0-codeql.1.
- Updates MODULE.bazel and associated module files to reference the reverted version, including an adjustment of the platforms dependency.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| misc/bazel/registry/modules/rules_kotlin/metadata.json | Reverted the rules_kotlin version to "2.0.0-codeql.1". |
| misc/bazel/registry/modules/rules_kotlin/2.1.3-codeql.1/source.json | Removed the source file for the broken version. |
| misc/bazel/registry/modules/rules_kotlin/2.0.0-codeql.1/source.json | Added the source file for the reverted version. |
| misc/bazel/registry/modules/rules_kotlin/2.0.0-codeql.1/patches/codeql_add_language_version_option.patch | Updated patch file context for v2.0.0-codeql.1. |
| misc/bazel/registry/modules/rules_kotlin/2.0.0-codeql.1/MODULE.bazel | Updated module file to use version "2.0.0-codeql.1" and adjusted the platforms dependency version. |
| MODULE.bazel | Updated dependency for rules_kotlin to "2.0.0-codeql.1". |
Comments suppressed due to low confidence (3)
misc/bazel/registry/modules/rules_kotlin/metadata.json:24
- Ensure that reverting back to version '2.0.0-codeql.1' is consistent with all other configuration files referencing rules_kotlin to avoid potential mismatches in the build.
"2.0.0-codeql.1"
misc/bazel/registry/modules/rules_kotlin/2.0.0-codeql.1/MODULE.bazel:8
- Verify that downgrading the 'platforms' dependency from 0.0.11 to 0.0.10 is intentional and does not introduce compatibility issues with other modules.
bazel_dep(name = "platforms", version = "0.0.10")
MODULE.bazel:27
- Confirm that updating the dependency for 'rules_kotlin' to '2.0.0-codeql.1' aligns with the overall project dependency strategy and that no stray references to the newer version remain.
bazel_dep(name = "rules_kotlin", version = "2.0.0-codeql.1")
sam-robson
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #19385: this actually breaks our build, which I didn't notice because of a CI quirk.