Codegen: make missing codeql error clearer
#19418
Merged
+31
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR aims to improve the clarity of the error message when the CodeQL binary is missing by updating both the generator and its corresponding tests.
- Updated test cases in misc/codegen/test/test_qlgen.py to simulate missing CodeQL binaries.
- Enhanced error messaging in misc/codegen/generators/qlgen.py by explicitly checking for the binary’s existence.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| misc/codegen/test/test_qlgen.py | Added tests to verify clearer error handling for missing CodeQL binary. |
| misc/codegen/generators/qlgen.py | Improved format() by adding explicit existence checks and informative error messages for the CodeQL binary. |
jketema
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.