Rust: extract declarations of builtin types #19421
Open
+126
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21aab9e to
c4aa719
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR implements the extraction of built-in type declarations in Rust and updates related build configurations and the extractor.
- Added a new file (types.rs) with declarations for built-in types.
- Updated Bazel BUILD files to include the new builtins sources.
- Extended the extractor to process the builtins directory during extraction.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| rust/tools/builtins/types.rs | Added declarations for built-in types. |
| rust/tools/builtins/BUILD.bazel | Defined a Bazel target for built-ins sources. |
| rust/extractor/src/main.rs | Enhanced extractor to include builtins in extraction. |
| rust/BUILD.bazel | Updated tools file group to reference built-ins. |
| @@ -276,5 +277,13 @@ fn main() -> anyhow::Result<()> { | |||
| } | |||
| } | |||
| } | |||
| let builtins_dir = env::var("CODEQL_EXTRACTOR_RUST_ROOT") | |||
There was a problem hiding this comment.
[nitpick] When iterating over the builtins directory, consider filtering for Rust source files (e.g., files ending with '.rs') to prevent the processing of unrelated files in case extra files are present.
Copilot uses AI. Check for mistakes.
8a02f98 to
050f949
Compare
050f949 to
371e519
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds extraction of declarations of built-in types.