Python: Extract hidden files/dirs by default #19424
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the default behaviour of the Python extractor so that hidden files (and files inside hidden directories) are extracted by default. Also adds an extractor option, `skip_hidden_files`, which can be set to `true` in order to revert to the old behaviour. Finally, I made the logic surrounding what is logged in various cases a bit more obvious. Technically this changes the behaviour of the extractor (in that hidden excluded files will now be logged as `(excluded)`, but I think this makes more sense anyway.
eef5a49 to
4d00556
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the default behaviour of the Python extractor so that hidden files (and files inside hidden directories) are extracted by default.
Also adds an extractor option,
skip_hidden_files, which can be set totruein order to revert to the old behaviour.Finally, I made the logic surrounding what is logged in various cases a bit more obvious.
Technically this changes the behaviour of the extractor (in that hidden excluded files will now be logged as
(excluded), but I think this makes more sense anyway.