Skip to content

Adding comprehensive docs for customizing actions/unpinned-tag query #19427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

felickz
Copy link
Contributor

@felickz felickz commented Apr 30, 2025

This pull request introduces documentation updates for customizing the behavior of the UnpinnedActionsTag query in CodeQL. The changes include detailed instructions on how to extend the list of trusted Action publishers and a reference link to the customization guide. Inspired by lack of visibility here: #18316 (comment)

Documentation Enhancements:

@Copilot Copilot AI review requested due to automatic review settings April 30, 2025 13:48
@felickz felickz requested a review from a team as a code owner April 30, 2025 13:48
@github-actions github-actions bot added documentation Actions Analysis of GitHub Actions labels Apr 30, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds documentation to help users customize the behavior of the UnpinnedActionsTag query by providing detailed configuration instructions and examples.

  • Updated UnpinnedActionsTag.md to include a reference link to the customization guide.
  • Added a new file, UnpinnedActionsTag-CUSTOMIZING.md, with step-by-step configuration instructions and examples.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
actions/ql/src/Security/CWE-829/UnpinnedActionsTag.md Added reference to the customizing guide to inform users about extending the trusted Action publishers list.
actions/ql/src/Security/CWE-829/UnpinnedActionsTag-CUSTOMIZING.md New documentation file with configuration steps and examples for customizing trusted Action publishers.

## References
- [Extending CodeQL coverage with CodeQL model packs in default setup](https://docs.github.com/en/code-security/code-scanning/managing-your-code-scanning-configuration/editing-your-configuration-of-default-setup#extending-codeql-coverage-with-codeql-model-packs-in-default-setup)
- [Creating and working with CodeQL packs](https://docs.github.com/en/code-security/codeql-cli/using-the-advanced-functionality-of-the-codeql-cli/creating-and-working-with-codeql-packs#creating-a-codeql-model-pack)
- [Customizing library models for GitHub Actions](https://codeql.github.com/docs/codeql-language-guides/customizing-library-models-for-actions/)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have the guidance you're adding in this page https://codeql.github.com/docs/codeql-language-guides/customizing-library-models-for-actions instead? I like the guidance, just prefer that location.
I ask because:

  • that is the location we point to for customising in general
  • it's in the public docs rather than just in our repo or the code scanning alert view
  • this -CUSTOMIZING.md file will be hard to discover, since it's not shipped
  • changing the query help .md file will influence Autofix suggestions, which I'd like to avoid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions Analysis of GitHub Actions documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants