QL tests: run with --check-diff-informed #19428
Open
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: another language that (currently) only has tests in github/codeql is Go: Lines 57 to 58 in a46f8fb https://github.com/github/codeql/blob/a46f8fb0d9533114f3c634d7ec1e09f4c8b1c505/go/actions/test/action.yml#L81-L82 codeql/.github/workflows/go-tests.yml Lines 38 to 39 in a46f8fb |
4dbf42e to
481afb8
Compare
481afb8 to
5bc962c
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates various CodeQL test commands to include the new --check-diff-informed flag, ensuring tests also evaluate diff-related checks.
- Updated test target in ruby/Makefile
- Modified CodeQL test commands in go/Makefile
- Added the flag to CodeQL test runs in multiple GitHub workflow files (.github/workflows/ruby-qltest.yml, ruby-qltest-rtjo.yml, and csharp-qltest.yml)
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ruby/Makefile | Added --check-diff-informed flag in the test target command. |
| go/Makefile | Inserted --check-diff-informed flag into test commands. |
| .github/workflows/ruby-qltest.yml | Updated test run command with the new flag. |
| .github/workflows/ruby-qltest-rtjo.yml | Updated test run command with the new flag. |
| .github/workflows/csharp-qltest.yml | Updated test run command with the new flag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.