Fix cwe tags to include leading zero #19429
Open
+39
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CWE tag annotations in the QL queries to use three-digit CWE numbers with leading zeros, aligning them with the query metadata style guide.
- Updates CWE-20, CWE-12, CWE-16, CWE-11, and CWE-14 tags to their three-digit formats (e.g. from cwe-20 to cwe-020).
- Improves consistency of metadata across Go, C#, and C++ query files.
Reviewed Changes
Copilot reviewed 38 out of 38 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go/ql/src/Security/CWE-020/UntrustedDataToUnknownExternalAPI.ql | Updated tag from cwe-20 to cwe-020 |
| go/ql/src/Security/CWE-020/UntrustedDataToExternalAPI.ql | Updated tag from cwe-20 to cwe-020 |
| go/ql/src/Security/CWE-020/SuspiciousCharacterInRegexp.ql | Updated tag from cwe-20 to cwe-020 |
| go/ql/src/Security/CWE-020/MissingRegexpAnchor.ql | Updated tag from cwe-20 to cwe-020 |
| go/ql/src/Security/CWE-020/IncompleteHostnameRegexp.ql | Updated tag from cwe-20 to cwe-020 |
| go/ql/src/Security/CWE-020/ExternalAPIsUsedWithUntrustedData.ql | Updated tag from cwe-20 to cwe-020 |
| csharp/ql/src/Security Features/CWE-248/MissingASPNETGlobalErrorHandler.ql | Updated tag from cwe-12 to cwe-012 |
| csharp/ql/src/Security Features/CWE-020/UntrustedDataToExternalAPI.ql | Updated tag from cwe-20 to cwe-020 |
| csharp/ql/src/Security Features/CWE-020/RuntimeChecksBypass.ql | Updated tag from cwe-20 to cwe-020 |
| csharp/ql/src/Security Features/CWE-020/ExternalAPIsUsedWithUntrustedData.ql | Updated tag from cwe-20 to cwe-020 |
| csharp/ql/src/Security Features/CWE-016/ASPNetPagesValidateRequest.ql | Updated tag from cwe-16 to cwe-016 |
| csharp/ql/src/Security Features/CWE-016/ASPNetMaxRequestLength.ql | Updated tag from cwe-16 to cwe-016 |
| csharp/ql/src/Security Features/CWE-011/ASPNetDebug.ql | Updated tag from cwe-11 to cwe-011 |
| csharp/ql/src/Configuration/PasswordInConfigurationFile.ql | Updated tag from cwe-13 to cwe-013 |
| cpp/ql/src/experimental/Security/CWE/CWE-020/LateCheckOfFunctionArgument.ql | Updated tag from cwe-20 to cwe-020 |
| cpp/ql/src/Security/CWE/CWE-020/UntrustedDataToExternalAPI.ql | Updated tag from cwe-20 to cwe-020 |
| cpp/ql/src/Security/CWE/CWE-020/IRUntrustedDataToExternalAPI.ql | Updated tag from cwe-20 to cwe-020 |
| cpp/ql/src/Security/CWE/CWE-020/IRCountUntrustedDataToExternalAPI.ql | Updated tag from cwe-20 to cwe-020 |
| cpp/ql/src/Security/CWE/CWE-020/CountUntrustedDataToExternalAPI.ql | Updated tag from cwe-20 to cwe-020 |
| cpp/ql/src/Security/CWE/CWE-014/MemsetMayBeDeleted.ql | Updated tag from cwe-14 to cwe-014 |
tausbn
approved these changes
Apr 30, 2025
|
There are more than 1000s CWEs. Example: https://cwe.mitre.org/data/definitions/1191.html. This also is not consistent with the numbering used by Mitre, which does not prefix the number with zeros. See, e.g., https://cwe.mitre.org/data/definitions/14.html. So I'm not sure if this is the way to go? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query metadata style guide gives examples where the cwe number has leading zeros to make it three digits, like
external/cwe/cwe-022. Most queries do this, but some are missing the leading zeros. This PR fixes that, and also one query that I noticed in passing had the wrong form for its CWE tags.I hope this doesn't need a change note for each language. Let me know if I'm wrong.