Skip to content

Rust: Remove visibility check in path resolution #19431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Apr 30, 2025

Visibility checking was originally introduced to reduce the number of path resolution inconsistencies. However, the current implementation is too restrictive, and even my attempt to make it less restrictive is still not good enough.

So, instead I have come to the conclusion that we are better off without visibility checking. This also aligns with our general assumption that programs are valid, for instance our type inference logic does not actually check that the program is well-typed.

DCA shows that we gain an additional 5 % true-positive call edges (up 385,386 from 367,484).

@github-actions github-actions bot added the Rust Pull requests that update Rust code label Apr 30, 2025
@hvitved hvitved force-pushed the rust/path-resolution-remove-visibility-check branch from 5335664 to edc38da Compare April 30, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant