Rust: Remove visibility check in path resolution #19431
Draft
+74
−63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visibility checking was originally introduced to reduce the number of path resolution inconsistencies. However, the current implementation is too restrictive, and even my attempt to make it less restrictive is still not good enough.
So, instead I have come to the conclusion that we are better off without visibility checking. This also aligns with our general assumption that programs are valid, for instance our type inference logic does not actually check that the program is well-typed.
DCA shows that we gain an additional 5 % true-positive call edges (up 385,386 from 367,484).