Rust: Update generated models for core and std #19440
Open
+1,368
−995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fe3152b to
499d224
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the generated CodeQL models for Rust’s core and std libraries to reflect recent library and CodeQL changes.
- Regenerated the
inline-flow.expecteddataflow test to match updated model outputs and provenance distances. - Extended the stdlib alloc model with a new
String::fromconversion entry.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rust/ql/test/library-tests/dataflow/modeled/inline-flow.expected | Reordered and renumbered summaries for Result::unwrap, ptr::read, ptr::write, and adjusted MaD values for source edges. |
| rust/ql/lib/codeql/rust/frameworks/stdlib/lang-alloc.model.yml | Added a manual model entry for <crate::string::String as crate::convert::From>::from. |
geoffw0
previously approved these changes
May 2, 2025
I agree. And as we scale things up it will make even less sense to try and manually verify them. I've merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just rerunning the model generator for
coreandstdand adding a manual value flow summary forString::from. I think that one might've been lost due to primitives not being extracted and hence method resolution now working ideally for builtins.