Rust: Add Operation class #19454
Open
Rust: Add Operation class #19454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a unified Operation class in the Rust QL library, letting all unary, binary, assignment, and logical expressions share a consistent interface with getOperatorName() and getAnOperand().
- Defined
OperationImpl::Operationand aliased it asOperation - Updated
PrefixExprandBinaryExprimplementations to mix inOperation - Added imports of
Operationin query modules and extended tests to exercise the new API
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rust/ql/lib/codeql/rust/elements/Operation.qll | Added the abstract Operation class and alias |
| rust/ql/lib/codeql/rust/elements/internal/PrefixExprImpl.qll | Extended PrefixExpr to implement Operation |
| rust/ql/lib/codeql/rust/elements/internal/BinaryExprImpl.qll | Extended BinaryExpr to implement Operation |
| rust/ql/test/library-tests/operations/test.rs | Expanded inline tests for various operators |
Comments suppressed due to low confidence (1)
rust/ql/test/library-tests/operations/test.rs:54
- No inline expectation is provided for the
?try operator. Consider adding an expectation comment, for example:// $ Operation Op=? Operands=1 PrefixExprto validate its classification and operands.
res?;
|
DCA shows nothing interesting, which is what we'd expect for a change like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify various classes representing operations under a single
Operationclass, providing a single consistent interface (withgetOperatorName()andgetAnOperand()) for reasoning about them.The idea is to get things in order before I follow up with another PR that will add new subclasses, allowing us to find things like the dereference expression (
*) and comparison operations more easily.