C++: Minor cleanup of qltest options #19508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The types are already enabled through the specfied gcc version.
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up test extractor option comments by removing redundant flags and deleting an obsolete options file.
- Deleted the
vector_types/optionsextractor options file. - Stripped out
--edgand--clang_vector_typesflags from two C test files.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cpp/ql/test/library-tests/vector_types/options | Removed the dedicated extractor options file for vector types tests |
| cpp/ql/test/library-tests/structs/compatible_c/c2_gnu.c | Dropped --edg and --clang_vector_types from the extractor options comment |
| cpp/ql/test/library-tests/structs/compatible_c/c1_gnu.c | Dropped --edg and --clang_vector_types from the extractor options comment |
Comments suppressed due to low confidence (3)
cpp/ql/test/library-tests/vector_types/options:1
- Removing this options file also drops the
--clang_vector_typesflag needed to extract vector_size attributes; vector types tests may fail. Consider preserving the flag or adding it to the default extractor options.
-semmle-extractor-options: --clang --edg --clang_builtin_functions --edg --clang_vector_types --gnu_version 40600
cpp/ql/test/library-tests/structs/compatible_c/c2_gnu.c:10
- The
--clang_vector_typesflag was removed but this test usesvector_sizeattributes; without it the extractor may not recognize vector types. Re-add--clang_vector_typesto the extractor options.
// semmle-extractor-options: -std=c99 --clang --gnu_version 40700
cpp/ql/test/library-tests/structs/compatible_c/c1_gnu.c:10
- The
--clang_vector_typesflag was removed but this test usesvector_sizeattributes; without it the extractor may not recognize vector types. Re-add--clang_vector_typesto the extractor options.
// semmle-extractor-options: -std=c99 --clang --gnu_version 40700
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits for details.