Quantum: Expand OpenSSL cipher modeling and fix JCA false reporting of intermediate calls #19509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolaswill
reviewed
May 16, 2025
| this.(Call).getTarget().getName() in [ | ||
| "EVP_EncryptFinal_ex", "EVP_DecryptFinal_ex", "EVP_CipherFinal_ex", "EVP_EncryptFinal", | ||
| "EVP_DecryptFinal", "EVP_CipherFinal" | ||
| ] | ||
| } | ||
|
|
||
| EVP_Update_Call getUpdateCalls() { | ||
| CTXFlow::ctxArgFlowsToCtxArg(result.getContextArg(), this.getContextArg()) |
There was a problem hiding this comment.
Suggest adding a flow configuration as in the JCA for properly modelling inputs and distinguishing between intermediate and final calls.
nicolaswill
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds modeling for EVP cipher update calls, flowing their inputs through to EVP cipher final calls.
Fixes a bug in JCA where intermediate cipher calls (updates) were being modeled as cipher operation instances.