C++: Address comments from earlier Windows MaD PRs #19599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR centralizes Windows type aliases in the external-models test file and updates the expected-outputs to match the shifted code locations.
- Moved and deduplicated
usingstatements for Windows types at the top ofwindows.cpp - Updated line references in
steps.expected,sources.expected, andflow.expectedto align with the code changes
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cpp/ql/test/library-tests/dataflow/external-models/windows.cpp | Moved Windows type aliases to the top of the file; removed duplicates |
| cpp/ql/test/library-tests/dataflow/external-models/steps.expected | Updated the CommandLineToArgvA call location line number |
| cpp/ql/test/library-tests/dataflow/external-models/sources.expected | Adjusted source entries to match new function positions |
| cpp/ql/test/library-tests/dataflow/external-models/flow.expected | Realigned flow graph entries with updated line offsets |
MathiasVP
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.