Rust: Extend jump-to-def to include paths and mod file; imports
#19605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27fd756 to
d74e95f
Compare
There was a problem hiding this comment.
Pull Request Overview
Adds support for resolving paths and file imports (mod file;) in Rust jump-to-definition.
- Introduce a
struct S,mod lib;, and reference inmain.rsfor new resolution tests - Update test query (
Definitions.ql) to only select source uses and refresh expected results (Definitions.expected) - Extend internal QL libraries (
PathResolution.qll,Definitions.qll) withfileImport,PathUse,FileUse, andItemNodesupport
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| rust/ql/test/library-tests/definitions/main.rs | Add struct S, mod lib;, and a let x = S usage for path resolution testing |
| rust/ql/test/library-tests/definitions/Definitions.ql | Filter Use to fromSource() in test query |
| rust/ql/test/library-tests/definitions/Definitions.expected | Updated expected table to include path and file entries |
| rust/ql/lib/codeql/rust/internal/PathResolution.qll | Added pragma[nomagic] on fileImport predicate |
| rust/ql/lib/codeql/rust/internal/Definitions.qll | Imported PathResolution, added TItemNode, extended Definition and defined PathUse & FileUse |
| @@ -1021,7 +1021,8 @@ private predicate pathAttrImport(Folder f, Module m, string relativePath) { | |||
| private predicate shouldAppend(Folder f, string relativePath) { pathAttrImport(f, _, relativePath) } | |||
|
|
|||
| /** Holds if `m` is a `mod name;` item importing file `f`. */ | |||
| private predicate fileImport(Module m, SourceFile f) { | |||
| pragma[nomagic] | |||
There was a problem hiding this comment.
[nitpick] After marking fileImport with pragma[nomagic], consider re-adding the private qualifier (e.g. pragma[nomagic] private predicate fileImport…) to keep its visibility scope intentional.
Suggested change
| pragma[nomagic] | |
| pragma[nomagic] private |
Copilot uses AI. Check for mistakes.
| @@ -3,6 +3,7 @@ | |||
| * in the code viewer. | |||
| */ | |||
|
|
|||
| private import rust | |||
There was a problem hiding this comment.
[nitpick] The private import rust line does not appear to be used by this module; you may remove it to avoid unnecessary imports.
Suggested change
| private import rust |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.