Rust: restrict line and file counts to include only extracted source files #19616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates summary queries to ensure metrics only include files extracted as source code.
- Added a
fromSource()filter togetLinesOfUserCode()to exclude non-source files. - Switched the file counter in
NumberOfFilesExtractedWithErrors.qlto operate onExtractedFileinstead ofFile.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| rust/ql/src/queries/summary/Stats.qll | Added f.fromSource() to the LOC sum to limit to source files. |
| rust/ql/src/queries/summary/NumberOfFilesExtractedWithErrors.ql | Changed count(File f) to count(ExtractedFile f) to target extracted files. |
geoffw0
reviewed
May 30, 2025
| @@ -35,7 +35,7 @@ int getLinesOfCode() { result = sum(File f | f.fromSource() | f.getNumberOfLines | |||
| * Gets a count of the total number of lines of code from the source code directory in the database. | |||
| */ | |||
| int getLinesOfUserCode() { | |||
| result = sum(File f | exists(f.getRelativePath()) | f.getNumberOfLinesOfCode()) | |||
| result = sum(File f | f.fromSource() and exists(f.getRelativePath()) | f.getNumberOfLinesOfCode()) | |||
There was a problem hiding this comment.
Can we not use ExtractedFile here as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should correct unexpected counts for "library" files that happen to be located in the source folder. For example source files that are excluded from extraction can still be extracted in "library" mode to aid type inference if other crates depend on them.