Java: Add previous-id and adjust tags for java/garbage-collection and java/run-finalizers-on-exit
#20095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and 'java/do-not-use-finalizers'
previous-id and adjust tags for java/garbage-collection and java/run-finalizers-on-exitprevious-id and adjust tags for java/garbage-collection and java/run-finalizers-on-exit
There was a problem hiding this comment.
Pull Request Overview
Adds previous-id metadata and adjusts tags for two Java queries (java/garbage-collection and java/run-finalizers-on-exit) to align with quality categorization standards. This follows up on query metadata standardization work.
- Replaces
maintainabilitytags with more specific quality-focused tags (quality,correctness,performance) - Adds
previous-idmetadata pointing tojava/do-not-use-finalizersfor both queries - Updates the code-quality-extended suite to include
java/run-finalizers-on-exit
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| java/ql/src/change-notes/2025-07-19-adjust-tags.md | Documents the tag changes for both queries |
| java/ql/src/Violations of Best Practice/Undesirable Calls/GarbageCollection.ql | Updates tags from maintainability to quality/correctness and adds previous-id |
| java/ql/src/Violations of Best Practice/Undesirable Calls/CallsToRunFinalizersOnExit.ql | Updates tags from maintainability to quality/correctness/performance and adds previous-id |
| java/ql/integration-tests/java/query-suite/java-code-quality-extended.qls.expected | Adds CallsToRunFinalizersOnExit.ql to the expected test suite results |
java/ql/src/Violations of Best Practice/Undesirable Calls/GarbageCollection.ql
Show resolved
Hide resolved
java/ql/src/Violations of Best Practice/Undesirable Calls/CallsToRunFinalizersOnExit.ql
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
previous-idand adjusts tags forjava/garbage-collectionandjava/run-finalizers-on-exit. Follow-up to #19075.This will add
java/run-finalizers-on-exitto the code-quality-extended suite.java/garbage-collectionwill not be added to any suite due to itslowprecision.