Java: use java 17 in no-wrapper tests
#20189
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle 9 requires Java 17.
There was a problem hiding this comment.
Pull Request Overview
Updates Java version requirement from Java 11 to Java 17 for no-wrapper integration tests to support Gradle 9 compatibility.
- Changes test function parameters from
use_java_11touse_java_17across four Android sample test files - Ensures compatibility with Gradle 9 which requires Java 17 as minimum version
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| java/ql/integration-tests/java/android-sample-old-style-no-wrapper/test.py | Updates test function to use Java 17 for old-style Android sample tests |
| java/ql/integration-tests/java/android-sample-old-style-kotlin-build-script-no-wrapper/test.py | Updates test function to use Java 17 for old-style Kotlin build script tests |
| java/ql/integration-tests/java/android-sample-no-wrapper/test.py | Updates test function to use Java 17 for standard Android sample tests |
| java/ql/integration-tests/java/android-sample-kotlin-build-script-no-wrapper/test.py | Updates test function to use Java 17 for Kotlin build script tests |
|
@smowton maybe you can chime in here? |
|
Per 4197d7b looks like I wanted "at least Java 11" so this is probably fine |
mbg
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradle 9 which has recently been rolled out to action images requires Java 17.
Closes https://github.com/github/semmle-code/issues/53694