-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Shared/basicblock signature3 #20318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
aschackmull
wants to merge
8
commits into
github:main
Choose a base branch
from
aschackmull:shared/basicblock-signature3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Shared/basicblock signature3 #20318
+798
−653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
final private class FinalBasicBlock = BasicBlock; | ||
|
||
module Cfg implements BB::CfgSig<DbLocation> { | ||
private import javascript as Js |
Check warning
Code scanning / CodeQL
Names only differing by case Warning
Js is only different by casing from js that is used elsewhere for modules.
Js is only different by casing from JS that is used elsewhere for modules.
Js is only different by casing from JS that is used elsewhere for modules.
deprecated private predicate lastRefSkipUncertainReadsExt( | ||
Definition def, SsaInput::BasicBlock bb, int i | ||
) { | ||
deprecated private predicate lastRefSkipUncertainReadsExt(Definition def, BasicBlock bb, int i) { |
Check warning
Code scanning / CodeQL
Missing QLDoc for parameter Warning
The QLDoc has no documentation for bb, or def, or i, but the QLDoc mentions lastRefRedef
this.hasValueBranchEdge(bb1, bb2, branch) | ||
} | ||
} | ||
|
||
/** Holds if the guard `guard` controls block `bb` upon evaluating to `branch`. */ | ||
predicate guardDirectlyControlsBlock(Guard guard, SsaInput::BasicBlock bb, GuardValue branch) { | ||
predicate guardDirectlyControlsBlock(Guard guard, BasicBlock bb, GuardValue branch) { |
Check warning
Code scanning / CodeQL
Dead code Warning
This code is never used, and it's not publicly exported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.