Skip to content

AST class reference for go #3675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2020

Conversation

owen-mc
Copy link
Contributor

@owen-mc owen-mc commented Jun 10, 2020

The master copy of this file is in the codeql-go repository

The master copy of this file is in the codeql-go repository
@owen-mc
Copy link
Contributor Author

owen-mc commented Jun 10, 2020

I see that the Docs/Generate-Sphinx check has failed, but I can't see the details because I don't have access to Semmle systems. The only thing I can think of off the top of my head is that I used a slightly different way of putting links in table cells than the other rst files I've seen.

@max-schaefer
Copy link
Contributor

The error is

16:45:25  Warning, treated as error:
16:45:25  /home/jenkins/slave/workspace/Docs/Generate-Sphinx/job/ql/docs/language/learn-ql/go/ast-class-reference.rst:document isn't included in any toctree

The file needs to be referenced from somewhere, but I don't remember off the top of head from where. Hopefully easy to figure out based on the other files.

@owen-mc owen-mc force-pushed the ast-class-reference-for-go branch from ad22c68 to d890044 Compare June 10, 2020 16:32
@max-schaefer max-schaefer merged commit cee2485 into github:rc/1.24 Jun 11, 2020
@max-schaefer
Copy link
Contributor

Apologies, @felicitymay / @shati-patel, I just realised I merged this without waiting for input from the doc team. Here is the preview in case you want to take a look; content is fine.

@shati-patel
Copy link
Contributor

Apologies, @felicitymay / @shati-patel, I just realised I merged this without waiting for input from the doc team. Here is the preview in case you want to take a look; content is fine.

Thanks @max-schaefer! I will take a look today 😃

@felicitymay
Copy link
Contributor

@shati-patel - I expect you've already thought of this, but just in case...
When we publish this, we also need to remember to update Emily's migration spreadsheet.

@owen-mc owen-mc deleted the ast-class-reference-for-go branch June 15, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants