Python: Add support for detecting XSLT Injection (#3521 revived) #3801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds support for detecting XSLT injection in Python. I have included the ql files as well as the tests with this.
As indicated here https://www.zaproxy.org/docs/alerts/90017/
yoff
previously approved these changes
Jun 26, 2020
python/ql/src/experimental/semmle/python/security/injection/XSLT.qll
Outdated
Show resolved
Hide resolved
python/ql/src/experimental/semmle/python/security/injection/XSLT.qll
Outdated
Show resolved
Hide resolved
tausbn
previously approved these changes
Jun 26, 2020
| @@ -0,0 +1,35 @@ | |||
| /** | |||
| * @name Xslt query built from user-controlled sources | |||
There was a problem hiding this comment.
I know discussing how to write acronyms is all the rage, but perhaps this should be XSLT for consistency?
There was a problem hiding this comment.
In the name, totally agree! (fix implemented)
I think the discussion would decide whether it should be called XSLT.ql or Xslt.ql
tausbn
approved these changes
Jun 26, 2020
|
@RasmusWL Thanks a lot for updating this and getting this merged into the code base. I just noticed that the ql used in #3801 #3521 #3522 won't detect the following case. I think this is a limitation in the current taint tracking library but I may be wrong. I am noting this down here to keep track of this. from lxml.etree import *
res = XPath('sink')or from lxml.etree import *
f = StringIO('<foo><bar></bar></foo>')
tree = parse(f)
r = tree.xpath("/tag[@id='%s']" % untrusted_value) |
This was referenced Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is bringing #3521 back from the dead (an external contribution).
I did some minor readjusting of the code, but nothing major.