Enable nullability checks on Semmle.Extraction.CIL #4113
Conversation
679b9bb to
9cdee63
Compare
| @@ -208,7 +208,7 @@ public override IEnumerable<IExtractionProduct> Contents | |||
|
|
|||
| PopulateParameters(typeSignature.ParameterTypes); | |||
|
|
|||
| foreach (var c in Parameters) | |||
| foreach (var c in Parameters!) | |||
There was a problem hiding this comment.
Why not just produce no results if Parameters is null?
There was a problem hiding this comment.
Parameters is never null here, because it's accessed after PopulateParameters() so we can safely use the !. But adding ?? Array.Empty<Parameter>() also works for me if that's what you meant?
There was a problem hiding this comment.
You can also use the EnumerateNull extension method from Semmle.Util.
There was a problem hiding this comment.
I just changed this to use EnumerateNull, but we're not winning anything because a couple of lines below we're indexing into the Parameters list, and I would need to add the ! there to not get a warning.
So in the end, I'm not going to change this line, I'll leave it as foreach (var c in Parameters!).
There was a problem hiding this comment.
Actually, I'm going to change PopulateParameters to return the parameters, and make the assignment to Parameters in the method, and then the compiler will know that it's assigned.
| @@ -465,7 +467,7 @@ public override IEnumerable<IExtractionProduct> Contents | |||
| var typeSignature = mr.DecodeMethodSignature(cx.TypeSignatureDecoder, this); | |||
|
|
|||
| PopulateParameters(typeSignature.ParameterTypes); | |||
| foreach (var p in Parameters) yield return p; | |||
| foreach (var p in Parameters!) yield return p; | |||
There was a problem hiding this comment.
Again, just skip the loop if Parameters is null.
| @@ -548,7 +551,7 @@ public override IEnumerable<IExtractionProduct> Contents | |||
| } | |||
|
|
|||
| PopulateParameters(constructedTypeSignature.ParameterTypes); | |||
| foreach (var p in Parameters) | |||
| foreach (var p in Parameters!) | |||
No description provided.