Skip to content

CWE-552: Switch to the shared PathSanitizer library #8055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

luchua-bc
Copy link
Contributor

Following up on the discussion at PR# 7712, this PR is to update the query committed by PR# 7286 - Java: CWE-552 Query to detect unsafe request dispatcher usage to switch to the shared library experimental.semmle.code.java.PathSanitizer.

With this change, code reusability is improved and it facilitates the future integration once the shared library is promoted from the experimental directory to the main directory.

Please consider to merge the PR. Thanks.

@luchua-bc luchua-bc requested a review from a team as a code owner February 16, 2022 16:18
@github-actions github-actions bot added the Java label Feb 16, 2022
@luchua-bc
Copy link
Contributor Author

luchua-bc commented Feb 16, 2022

@smowton and @atorralba - please review this PR when you have a chance.

And I guess you will submit the PR to promote the PathSanitizer library to main since you will fine tune the library. Please advise if you want me to submit that PR instead. Thanks.

@atorralba atorralba merged commit f011bbc into github:main Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants