Testing overhaul #26
Merged
Testing overhaul #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbrignull
approved these changes
May 11, 2020
There was a problem hiding this comment.
Couple of points on triggers for actions, but otherwise looks like what we discussed and seems to work. As a sanity check I made a branch based on this one but with an intentional bug. The tests caught it, so I'm happy: https://github.com/github/codeql-action/actions/runs/101616470
|
|
||
| on: [pull_request] | ||
| on: [push] |
There was a problem hiding this comment.
Don't we want these to run against pull requests? Running on both push and pull_request would make sense to me.
| @@ -3,20 +3,115 @@ name: "Integration Testing" | |||
| on: [push] | |||
There was a problem hiding this comment.
This should run on pull_request too, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how we do integration testing. We decided to not run integration tests agains open source repos, and instead run them against synthetic mini repos stored in the tests folder.
Merge / deployment checklist