Skip to content

Conversation

robertbrignull
Copy link
Contributor

Enables source maps for the typescript compilation. The tangible benefit this will currently provide is that test errors will be reported in terms of the typescript line number instead of the javascript line number.

In future we might be able to get typescript line numbers in production error stack traces too, but currently I can't find a way to pass the --enable-source-maps option to nodejs and the actions team have confirmed this isn't currently possible.

Merge / deployment checklist

  • Run test builds as necessary. Can be on this repository or elsewhere as needed in order to test the change - please include links to tests in other repos!
    • CodeQL using init/analyze actions
    • 3rd party tool using upload action
  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

@robertbrignull robertbrignull merged commit 6507fba into master May 14, 2020
@robertbrignull robertbrignull deleted the source_maps branch May 14, 2020 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants