Skip to content

Move an error check to a more correct location. #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Conversation

chrisgavin
Copy link
Collaborator

staticcheck seems to say that it's preferable to check for errors before a defer .Close(), which I suppose does make sense so this PR makes that change.

@chrisgavin chrisgavin marked this pull request as ready for review May 30, 2022 18:50
@chrisgavin chrisgavin requested a review from simon-engledew June 1, 2022 08:20
@chrisgavin chrisgavin merged commit d451bb4 into main Jun 14, 2022
@chrisgavin chrisgavin deleted the move-error-check branch June 14, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants