-
Notifications
You must be signed in to change notification settings - Fork 135
Some files missing after database creation #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We crash while extracting that file so it doesn't end up in the database. We can reproduce it and we are working on a fix. |
Can you please give the output of |
Hi Matt,
I'm using the latest released version downloaded from this github repo |
Thank you for that info. I have identified several different issues which in our code base which are being triggered by the fuchsia build. I am working on fixes - but unfortunately they are unlikely to land in the next release of CodeQL. I will keep you updated on how the work is going through this ticket. |
Cool! Let me know if there's anything I can do to help. |
We have fixes internally now for a couple of the main issues ( |
(@matt-gretton-dann actually 2.0.3 will probably be a point release after 2.0.2 to fix just a single brown-paper-bag bug, and probably out tomorrow. The one that contains your fixes this will then be 2.0.4). |
Do you know if the change made it a release? We are at 2.1.0 |
|
I ran the following query to list all the files:
I see 8046 different files. And also gathered all the files from compile_commands.json used during compilation in fuchsia (both in out/default and out/default.zircon). Doing a sort | uniq, I get 9320 different cc files. This means that there are ~1.3k files that are missing. This gist contains the list of files in the db and in compile_commands.json. Some examples of missing files (by eye) are some of the autogenerated fidl files, some unit tests, and some random files that I have no idea why are missing. |
Hi! I've re-ran this test with CodeQL CLI version 2.2.4, and found similar results. By looking only at c and cc files, I see that there are 1140 missing files from the database, albeit ~700 of them are test files, but they do appear in compile_commands.json. |
@mvanotti Are you still running into this? |
While trying to create a database for the fuchsia operating system, it seems to leave out some of the files that were built.
Note that the steps to build fuchsia and a codeql database require ~200GB of disk space. I just want to get a better understanding of why it might be skipping some of the files.
Steps to reproduce:
fx set workstation.x64 --with-base //bundles:kitchen_sink --no-goma
codeql database create fuchsia-ql --language=cpp --source-root=${FUCHSIA_DIR} --command="./scripts/fx clean-build"
find ${FUCHSIA_DIR} -iname "*.cc" | grep -v "third_party"
This is the list that I have in my system. In particular, files like
/zircon/tools/zbi/zbi.cc
should always be built.To get a list of all the compiled files in fuchsia, run:
fx compdb
and then look atout/default/compile_commands.json
andout/default.zircon/compile_commands.json
The text was updated successfully, but these errors were encountered: