Skip to content
This repository was archived by the owner on Jan 5, 2023. It is now read-only.

Update AST class reference #173

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Update AST class reference #173

merged 1 commit into from
Jun 11, 2020

Conversation

owen-mc
Copy link
Contributor

@owen-mc owen-mc commented Jun 11, 2020

@owen-mc owen-mc requested a review from max-schaefer June 11, 2020 14:27
@max-schaefer
Copy link
Contributor

LGTM, but can you make it target rc/1.24, please?

@owen-mc owen-mc changed the base branch from master to rc/1.24 June 11, 2020 15:07
@owen-mc owen-mc force-pushed the update-ast-class-reference branch from 0a23dd4 to 71005f1 Compare June 11, 2020 15:08
@owen-mc
Copy link
Contributor Author

owen-mc commented Jun 11, 2020

Doh, I'm not used to this work flow with release branches.

@max-schaefer
Copy link
Contributor

Yeah, it's not the most elegant thing in the world.

@max-schaefer max-schaefer merged commit 9e3681c into github:rc/1.24 Jun 11, 2020
@owen-mc owen-mc deleted the update-ast-class-reference branch June 11, 2020 15:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@max-schaefer max-schaefer max-schaefer approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owen-mc @max-schaefer