Skip to content

Ignore hidden options #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 3, 2020
Merged

Ignore hidden options #16

merged 3 commits into from
Feb 3, 2020

Conversation

muan
Copy link
Contributor

@muan muan commented Dec 4, 2019 •
edited
Loading

Ensure only visible items are focused on. For reference github/details-dialog-element#48

@muan muan requested a review from a team December 13, 2019 20:40
@muan muan marked this pull request as ready for review December 13, 2019 20:40
koddsson
koddsson approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@koddsson koddsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👌

@muan muan merged commit 6b33f04 into master Feb 3, 2020
@muan muan deleted the hidden branch February 3, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithamus keithamus keithamus approved these changes

@koddsson koddsson koddsson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muan @keithamus @koddsson