This repository was archived by the owner on Sep 22, 2022. It is now read-only.
Fix shift tab when currentIndex is 0 or -1 #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muan
commented
Nov 6, 2019
| const currentFocus = elements.filter(el => el.matches(':focus'))[0] | ||
| let targetIndex = 0 | ||
| const currentFocus = dialog.contains(document.activeElement) ? document.activeElement : null | ||
| let targetIndex = movement === -1 ? -1 : 0 | ||
|
|
||
| if (currentFocus) { |
There was a problem hiding this comment.
When currentFocus does not exist, movement was not apply at all.
|
|
||
| if (currentFocus) { | ||
| const currentIndex = elements.indexOf(currentFocus) | ||
| if (currentIndex !== -1) { | ||
| const newIndex = currentIndex + movement | ||
| if (newIndex >= 0) targetIndex = newIndex % elements.length |
There was a problem hiding this comment.
When newIndex is -1 ((currentIndex)0 + (movement)-1), targetIndex stays 0.
| assert(!details.open) | ||
| }) | ||
|
|
||
| it('manages focus', async function() { | ||
| summary.click() | ||
| await waitForToggleEvent(details) | ||
| assert.equal(document.activeElement, dialog) | ||
| pressTab(details) | ||
| triggerKeydownEvent(details, 'Tab', true) |
There was a problem hiding this comment.
New test for shift + tab here.
keithamus
approved these changes
Nov 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will comment inline to point out where the bugs come from.
Bonus: instead of
.initEventthis updates the test to use the proper event class constructors.