This repository was archived by the owner on Sep 22, 2022. It is now read-only.
Make sure to scroll any overflow #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koddsson
commented
Sep 13, 2021
joelhawksley
approved these changes
Sep 13, 2021
dgreif
approved these changes
Sep 13, 2021
keithamus
approved these changes
Sep 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that the dialog is scrollable when the dialog is larger than the display. You can test out this change on the example page by making the browser window smaller in height than the dialog. See the example section for examples.
Examples
Before this change
Screen.Recording.2021-09-13.at.14.05.45.mov
After this change
Screen.Recording.2021-09-13.at.14.05.56.mov