This repository was archived by the owner on Sep 22, 2022. It is now read-only.
Support method="dialog" dismissal
#71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithamus
approved these changes
Sep 15, 2021
71d937e to
d540d3c
Compare
keithamus
approved these changes
Sep 15, 2021
The `<dialog>` element specifications support dismissing an open element by submitting a `<form method="dialog">` or by submitting a `<form>` with a `<button formmethod="dialog">` element. This commit adds support for either of those methods as an alternative to a `<button type="button" data-dialog-close>` element. [method="dialog"]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog#usage_notes
d540d3c to
2aa3a08
Compare
seanpdoyle
commented
Sep 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
<dialog>element specifications support dismissing an open elementby submitting a
<form method="dialog">or by submitting a<form>with a
<button formmethod="dialog">element.This commit adds support for either of those methods as an alternative
to a
<button type="button" data-dialog-close>element.