Skip to content

Autofocus fix #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 21, 2021
Merged

Autofocus fix #51

merged 4 commits into from
Jul 21, 2021

Conversation

pablonete
Copy link
Contributor

@pablonete pablonete commented Jul 20, 2021 •
edited
Loading

If the dropdown itself is the autofocus field in the page, then <details-menu> fails to set focus to any other autofocus element in the popup when displaying it.
Reason being that the selector matches first the <summary> and wrongly sets focus to it instead of any autofocus element inside the details-menu.
An example was added to demonstrate the issue. It fails currently using the @latest version, but it's fixed when using dist.

  • Write a test that covers this case.

pablonete added 2 commits July 20, 2021 17:24
@pablonete
Ignore summary when focusing to autofocus in the popup
91ca4de 
If the dropdown itself is the `autofocus` field in the page, then `<details-menu>` fails to set focus to any other `autofocus` element in the popup when displaying it.
Reason being that the selector matches first the `<summary>` and wrongly sets focus to it instead.
@pablonete
Add example of autofocus
a016867
@pablonete pablonete requested a review from koddsson July 20, 2021 15:56
@pablonete pablonete requested a review from a team as a code owner July 20, 2021 15:56
@pablonete pablonete requested a review from bscofield July 20, 2021 15:56
manuelpuyol
manuelpuyol reviewed Jul 20, 2021
View reviewed changes
Copy link
Contributor

@manuelpuyol manuelpuyol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm, but would love to see a test :)

darthwillis
darthwillis approved these changes Jul 20, 2021
View reviewed changes
Copy link

@darthwillis darthwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good change to me. A test would be great to ensure it doesn't regress.

koddsson
koddsson approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@koddsson koddsson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me once we add a test ✨

pablonete and others added 2 commits July 21, 2021 11:36
@pablonete
Add test for the fixed scenario.
6c5c99e
@pablonete
Drop placeholder.
342e80f 
Co-authored-by: Kristján Oddsson <koddsson@github.com>
@koddsson koddsson merged commit 202237d into github:main Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelpuyol manuelpuyol manuelpuyol left review comments

@koddsson koddsson koddsson approved these changes

@darthwillis darthwillis darthwillis approved these changes

@bscofield bscofield Awaiting requested review from bscofield bscofield was automatically assigned from github/web-systems-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pablonete @koddsson @manuelpuyol @darthwillis