Skip to content

change -s to -S in gpg verification codespaces page #10127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 6, 2021
Merged

change -s to -S in gpg verification codespaces page #10127

merged 9 commits into from
Oct 6, 2021

Conversation

CyberFlameGO
Copy link
Contributor

Why:

adding -s signs-off the commit (just some text at the bottom of a commit message), whereas -S signs the commit

Closes #10126

What's being changed:

A box at the bottom of https://docs.github.com/en/codespaces/managing-your-codespaces/managing-gpg-verification-for-codespaces

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Sep 17, 2021
@ramyaparimi ramyaparimi added Codespaces Content relating to GitHub Codespaces content This issue or pull request belongs to the Docs Content team and removed triage Do not begin working on this issue until triaged by the team labels Sep 17, 2021
@ramyaparimi
Copy link
Contributor

@CyberFlameGO
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@Dez6ztt

This comment has been minimized.

Sign in to view
lecoursen
lecoursen reviewed Oct 5, 2021
View reviewed changes
Copy link
Member

@lecoursen lecoursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ⚡

@lecoursen lecoursen added the ready to merge This pull request is ready to merge label Oct 5, 2021
@lecoursen lecoursen enabled auto-merge October 5, 2021 18:51
@lecoursen lecoursen merged commit ef08403 into github:main Oct 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lecoursen lecoursen lecoursen approved these changes

Assignees
No one assigned
Labels
Codespaces Content relating to GitHub Codespaces content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change flag case
4 participants
@CyberFlameGO @ramyaparimi @Dez6ztt @lecoursen