Skip to content

Update identifying-and-authorizing-users-for-github-apps.md #10460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 6, 2021
Merged

Update identifying-and-authorizing-users-for-github-apps.md #10460

merged 4 commits into from
Oct 6, 2021

Conversation

jleven
Copy link
Contributor

@jleven jleven commented Oct 1, 2021 •
edited by ramyaparimi
Loading

It was a little tricky to understand which steps in the flow are redirecting the user in their browser, and which are API calls. I've tried to clarify that.

Why:

Closes #10461. (issue I just made 😅 )

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@jleven
Update identifying-and-authorizing-users-for-github-apps.md
cfb984a 
It was a little tricky to understand which steps in the flow are redirecting the user in their browser, and which are API calls. I've tried to clarify that.
@welcome
Copy link

welcome bot commented Oct 1, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 1, 2021
@jleven jleven mentioned this pull request Oct 1, 2021
Closed
1 task
@ramyaparimi
Copy link
Contributor

@jleven
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Oct 4, 2021
guntrip
guntrip reviewed Oct 6, 2021
View reviewed changes
Copy link
Contributor

@guntrip guntrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jleven Thanks so much for submitting this! I think clarifying who is making each request is going to make this much easier to follow ✨

I've made one little change (you can find an explanation in the review comment) which I'll apply now and get this merged in. Thanks again for contributing to our documentation!

@guntrip guntrip enabled auto-merge (squash) October 6, 2021 11:53
@guntrip guntrip merged commit 898f718 into github:main Oct 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guntrip guntrip guntrip approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can we clarify the Identifying and Authorizing Users for GitHub Apps doc a bit?
3 participants
@jleven @ramyaparimi @guntrip