Skip to content

Fix link to pat upgrade section #21647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 27, 2022
Merged

Fix link to pat upgrade section #21647

merged 3 commits into from
Oct 27, 2022

Conversation

bodograumann
Copy link
Contributor

@bodograumann bodograumann commented Oct 27, 2022 •
edited
Loading

Just changing the fixed anchor name, but it might be better to use a function which converts the variable to kebab-case.

Why:

Fixes some links that didn't work.

What's being changed (if available, include any code snippets, screenshots, or gifs):

Fix the targeted anchor name.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@bodograumann
Fix link to pat upgrade section
efc2d00 
Just changing the fixed anchor name, but it might be better to use a function which converts the variable to kebab-case.
@welcome
Copy link

welcome bot commented Oct 27, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 27, 2022
@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team packages This issue or pull request should be reviewed by the docs packages team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Oct 27, 2022
@cmwilson21
Copy link
Contributor

@bodograumann Thanks so much for opening a PR! I'll get this triaged for review ⚡

@lecoursen lecoursen enabled auto-merge October 27, 2022 17:55
@lecoursen lecoursen merged commit 6844ff4 into github:main Oct 27, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@bodograumann bodograumann deleted the patch-1 branch October 27, 2022 22:05
@cmwilson21 cmwilson21 added the hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! label Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lecoursen lecoursen lecoursen approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! packages This issue or pull request should be reviewed by the docs packages team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bodograumann @cmwilson21 @lecoursen