Skip to content

Update configuring-github-copilot-in-visual-studio.md #24260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 3, 2023
Merged

Update configuring-github-copilot-in-visual-studio.md #24260

merged 4 commits into from
Mar 3, 2023

Conversation

liorbp
Copy link
Contributor

@liorbp liorbp commented Mar 2, 2023

Why:

Default shortcuts for VS are wrong

What's being changed (if available, include any code snippets, screenshots, or gifs):

Fix to show the right default shortcuts

@liorbp
Update configuring-github-copilot-in-visual-studio.md
d71aa61 
Default shortcuts for VS are wrong
@welcome
Copy link

welcome bot commented Mar 2, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
copilot/configuring-github-copilot/configuring-github-copilot-in-visual-studio.md fpt
ghec
 fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

@liorbp Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review copilot Content related to GitHub Copilot and removed triage Do not begin working on this issue until triaged by the team labels Mar 2, 2023
@hubwriter
Copy link
Contributor

@liorbp - Many thanks for raising this PR.

I'd like to hold off merging this PR just now while I investigate this a little. As a VS Code, but not Visual Studio, user, I believe the default keyboard shortcuts in Visual Studio:

should be the same as the shortcuts for VS Code:

If this is the case I think we should repeat the shortcut information currently used for VS Code on the page for Visual Studio.

@hubwriter hubwriter self-requested a review March 3, 2023 09:46
@hubwriter hubwriter added blocked This issue or PR is currently blocked and removed waiting for review Issue/PR is waiting for a writer's review labels Mar 3, 2023
hubwriter
hubwriter approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@hubwriter hubwriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @liorbp 👍

I've confirmed the shortcuts (which are not the same as for VS Code). I've made a slight change: accepting the next suggestion is Alt+.

I'll get this merged.
Many thanks again for going out of your way to correct this.
Much appreciated. 🥇

@hubwriter hubwriter enabled auto-merge (squash) March 3, 2023 11:12
@liorbp
Copy link
Contributor Author

liorbp commented Mar 3, 2023 •
edited
Loading

@hubwriter Thanks for reviewing.
I agree the shortcut should be aligned between VS Code and Visual Studio.
Unfortunately this is not the case right now and the documentation is misleading.

Thanks for the small fix, sorry for the typo.

@hubwriter hubwriter merged commit 8d7d378 into github:main Mar 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@MahirAbdulatif42
Copy link

Opening contract

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubwriter hubwriter hubwriter approved these changes

Assignees
No one assigned
Labels
blocked This issue or PR is currently blocked content This issue or pull request belongs to the Docs Content team copilot Content related to GitHub Copilot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liorbp @cmwilson21 @hubwriter @MahirAbdulatif42