Skip to content

Update CONTRIBUTING.md #28744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 2, 2023
Merged

Update CONTRIBUTING.md #28744

merged 2 commits into from
Oct 2, 2023

Conversation

sanusisusi
Copy link
Contributor

add (file) at the end of readme

Why:

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.

@sanusisusi
Update CONTRIBUTING.md
932fde1 
add (file) at the end of readme
@welcome
Copy link

welcome bot commented Oct 2, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 2, 2023
@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Oct 2, 2023
cmwilson21
cmwilson21 approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@cmwilson21 cmwilson21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@cmwilson21 cmwilson21 added the contributing docs Content related to our contributing docs label Oct 2, 2023
@cmwilson21
Copy link
Contributor

@sanusisusi Thanks for the PR! I agree it makes the sentence a bit more clear. I'll get this merged once all the checks have passed 👍

@cmwilson21 cmwilson21 added hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! ready to merge This pull request is ready to merge labels Oct 2, 2023
@cmwilson21 cmwilson21 enabled auto-merge October 2, 2023 14:15
@cmwilson21 cmwilson21 added this pull request to the merge queue Oct 2, 2023
Merged via the queue into github:main with commit 9cd2399 Oct 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@cmwilson21 cmwilson21 cmwilson21 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team contributing docs Content related to our contributing docs hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanusisusi @cmwilson21