Repo sync #37991
Merged
Repo sync #37991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: mchammer01 <42146119+mchammer01@users.noreply.github.com>
Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com>
Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This automated sync PR aligns the public and private repositories by updating REST schemas, introducing a new CTA popover context, adding UI fixtures, and refreshing documentation.
- Updated multiple
schema.jsonfiles for GHES, GHEC, and FPT:
• Expandedresolution_commentdescription
• Added a new/users/{username}/settings/billing/usageendpoint and HTTP 422 status code - Introduced
CTAPopoverProvideranduseCTAPopoverContext, integrated inapp.tsxandHeader.tsx, and added corresponding UI fixtures - Added a guide on auto-closing issues and corrected a model reference in the Copilot docs
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/rest/data/ghes-3.16-2022-11-28/schema.json | Updated resolution_comment description |
| src/rest/data/ghec-2022-11-28/schema.json | Added billing usage endpoint and 422 status code |
| src/rest/data/fpt-2022-11-28/schema.json | Added billing usage endpoint and 422 status code |
| src/github-apps/lib/config.json | Updated sync commit SHA |
| src/github-apps/data/ghec-2022-11-28/user-to-server-rest.json | Registered new billing usage endpoint slug |
| src/github-apps/data/ghec-2022-11-28/server-to-server-permissions.json | Added permissions for billing usage endpoint |
| src/github-apps/data/ghec-2022-11-28/fine-grained-pat.json | Registered new billing usage endpoint slug |
| src/github-apps/data/ghec-2022-11-28/fine-grained-pat-permissions.json | Added PAT permissions for billing usage endpoint |
| src/github-apps/data/fpt-2022-11-28/user-to-server-rest.json | Registered new billing usage endpoint slug |
| src/github-apps/data/fpt-2022-11-28/server-to-server-permissions.json | Added permissions for billing usage endpoint |
| src/github-apps/data/fpt-2022-11-28/fine-grained-pat.json | Registered new billing usage endpoint slug |
| src/github-apps/data/fpt-2022-11-28/fine-grained-pat-permissions.json | Added PAT permissions for billing usage endpoint |
| src/frame/pages/app.tsx | Wrapped the app in CTAPopoverProvider |
| src/frame/components/page-header/Header.tsx | Hooked into CTA context and initialized CTA on render |
| src/frame/components/context/CTAContext.tsx | New context and provider for CTA popover |
| src/fixtures/fixtures/data/ui.yml | Added CTA heading and description |
| data/ui.yml | Added CTA heading and description |
| content/.../managing-repository-settings/managing-auto-closing-issues.md | New doc for managing auto-closing issues |
| content/.../managing-repository-settings/index.md | Linked to the new auto-closing issues guide |
| content/copilot/.../choosing-the-right-ai-model-for-your-task.md | Corrected the AI model reference from o1 to o3-mini |
Comments suppressed due to low confidence (1)
src/frame/components/context/CTAContext.tsx:37
- The new
CTAPopoverProvideranduseCTAPopoverContexthook lack dedicated unit tests. Add tests to cover initial open state, theinitializeCTAlogic, and thedismissbehavior to ensure robustness.
export function CTAPopoverProvider({ children }: PropsWithChildren) {
Comment on lines
+67
to
71
| } else { | ||
| initializeCTA() | ||
| } | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
Calling initializeCTA() directly during render causes a state update in the render phase. Move this call into a useEffect that depends on showNewSearch to avoid side effects in the render path.
Suggested change
| } else { | |
| initializeCTA() | |
| } | |
| useEffect(() => { | |
| } | |
| useEffect(() => { | |
| if (showNewSearch) { | |
| initializeCTA() | |
| } | |
| }, [showNewSearch]) | |
| useEffect(() => { |
Copilot uses AI. Check for mistakes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated pull request to sync changes between the public and private repos.
Our bot will merge this pull request automatically.
To preserve continuity across repos, do not squash this pull request.