Skip to content

Create npm-gulp.yml #39781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Create npm-gulp.yml #39781

wants to merge 1 commit into from

Conversation

Will100001
Copy link

@Will100001 Will100001 commented Aug 11, 2025

Why:

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the review environment.

@Copilot Copilot AI review requested due to automatic review settings August 11, 2025 19:00
Copy link

welcome bot commented Aug 11, 2025

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new GitHub Actions workflow file for running Node.js builds with Gulp. The workflow is configured to run on pushes and pull requests to the main branch, testing across multiple Node.js versions.

Key changes:

  • Creates a new CI workflow using GitHub Actions
  • Configures multi-version Node.js testing (18.x, 20.x, 22.x)
  • Sets up automated npm install and gulp build processes

with:
node-version: ${{ matrix.node-version }}

- name: Build
Copy link
Preview

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build step is incomplete. According to the repository guidelines, code validation should include multiple steps: 'npm run tsc', 'npm run build', 'npm run prettier', and 'npm run lint'. Consider renaming this step and adding the missing validation commands.

Copilot uses AI. Check for mistakes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok fix

This comment was marked as spam.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 11, 2025
Copy link
Contributor

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions:

  • .github/workflows/npm-gulp.yml

You'll need to revert all of the files you changed that match that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

The complete list of files we can't accept are:

  • .devcontainer/**
  • .github/**
  • data/reusables/rai/**
  • Dockerfile*
  • src/**
  • package*.json
  • content/actions/how-tos/security-for-github-actions/security-hardening-your-deployments/**

We also can't accept contributions to files in the content directory with frontmatter type: rai or contentType: rai.

Copy link
Contributor

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

Note: Please update the URL for your staging server or codespace.

This pull request contains code changes, so we will not generate a table of review links.

🤖 This comment is automatically generated.

@Will100001
Copy link
Author

This pull request introduces a new GitHub Actions workflow for building Node.js projects with Gulp. The workflow is triggered on pushes and pull requests to the main branch and sets up builds across multiple Node.js versions.

Continuous Integration setup:

  • Added a new workflow file .github/workflows/npm-gulp.yml to automate building the project using Node.js and Gulp on pushes and pull requests to the main branch.
  • Configured the workflow to run on Ubuntu and test against Node.js versions 18.x, 20.x, and 22.x using a matrix strategy.
  • Included steps for checking out the code, setting up the correct Node.js version, installing dependencies, and running the Gulp build process.

Copy link
Author

@Will100001 Will100001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit

Copy link
Author

@Will100001 Will100001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix

@Hafiz0147

This comment was marked as spam.

@Hafiz0147

This comment was marked as spam.

Hafiz0147

This comment was marked as spam.

@Sharra-writes Sharra-writes added invalid This issue/PR is invalid and removed triage Do not begin working on this issue until triaged by the team labels Aug 12, 2025
@github-actions github-actions bot closed this Aug 12, 2025
@Sharra-writes Sharra-writes removed the invalid This issue/PR is invalid label Aug 12, 2025
@Sharra-writes
Copy link
Contributor

@Will100001 Sorry, we don't allow open source contributions on this kind of file. Our documentation is open source, not our workflows or the codebase for the site. We only accept contributions to files inside the "content" folder, and only the markdown files there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants