-
Notifications
You must be signed in to change notification settings - Fork 62.8k
Create npm-gulp.yml #39781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create npm-gulp.yml #39781
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new GitHub Actions workflow file for running Node.js builds with Gulp. The workflow is configured to run on pushes and pull requests to the main branch, testing across multiple Node.js versions.
Key changes:
- Creates a new CI workflow using GitHub Actions
- Configures multi-version Node.js testing (18.x, 20.x, 22.x)
- Sets up automated npm install and gulp build processes
with: | ||
node-version: ${{ matrix.node-version }} | ||
|
||
- name: Build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build step is incomplete. According to the repository guidelines, code validation should include multiple steps: 'npm run tsc', 'npm run build', 'npm run prettier', and 'npm run lint'. Consider renaming this step and adding the missing validation commands.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok fix
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions:
You'll need to revert all of the files you changed that match that list using GitHub Desktop or The complete list of files we can't accept are:
We also can't accept contributions to files in the content directory with frontmatter |
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. This pull request contains code changes, so we will not generate a table of review links. 🤖 This comment is automatically generated. |
This pull request introduces a new GitHub Actions workflow for building Node.js projects with Gulp. The workflow is triggered on pushes and pull requests to the Continuous Integration setup:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
@Will100001 Sorry, we don't allow open source contributions on this kind of file. Our documentation is open source, not our workflows or the codebase for the site. We only accept contributions to files inside the "content" folder, and only the markdown files there. |
Why:
Closes:
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following: