Add new linter for inline CSS #104
Conversation
|
Converting to Draft per our Slack chat! Please ping us when this is ready for review! |
|
👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Primer first responder will review it soon.
|
There was a problem hiding this comment.
One thought to start with - since this lint rule is Primer-specific, could it make sense for this rule to be part of existing ERB linters exported by PVC?
It's not exactly primer specific, we were trying to come up with a way to run stylelint more broadly on That's why our first inclination was to put it as a separate repo https://github.com/primer/erblint-stylelint maybe would be useful for the community? 🤷🏻 |
There was a problem hiding this comment.
@jonrohan I see!
I notice there's a stylelint config added to this repo, along with a npm install call in the CI step.
If I'm understanding correctly, the consuming application of this rule would have to make sure to install stylelint npm dependencies as a step in their lint workflow, and would also have to provide their own stylelint config in order to run this rule, right? It looks like the setup here doesn't carry over when this rule is called by a consumer, but would appreciate confirmation! This rule is nested under Primer but it seems like it would just use whatever stylelint config is configured by the consuming application?
| run: bundle install | ||
| run: | | ||
| bundle install | ||
| npm install |
There was a problem hiding this comment.
I'm assuming this npm install call would need to be added as a step in the consuming application, like dotcom?
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "extends": ["@primer/stylelint-config"], | |||
There was a problem hiding this comment.
I'm assuming that the consuming application needs to set their own stylelint config, and that this config is only applicable to the lint runs within this repo?
|
Closing as we moved this to dotcom 😄 |
Copied from @jonrohan in https://github.com/primer/erblint-stylelint
Adds a new linter for inline CSS
styletagsCloses https://github.com/github/primer/issues/2348