Skip to content

Remove counter and counter default for no-generic-link-text #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove counter and counter default for no-generic-link-text #58

wants to merge 1 commit into from

Conversation

khiga8
Copy link
Collaborator

@khiga8 khiga8 commented Apr 3, 2023

Relates to: #56
Similar to #57 but for no-generic-link-text

  • Deprecate the counter from the name
  • Make the counter system configurable and not the default

@khiga8 khiga8 requested a review from a team as a code owner April 3, 2023 12:35
@khiga8 khiga8 requested a review from accessibility-bot April 3, 2023 12:35
@accessibility-bot
Copy link

👋 Hello and thanks for pinging us! An accessibility first responder will review this soon.

  • 💻 On PRs for our review: please provide a review environment with steps to validate, screenshots (with alt text), or videos demonstrating functionality we should be checking. This will help speed up our review and feedback cycle.
  • ⚠️ If this is urgent, please visit us in #accessibility on Slack and tag the first responder(s) listed in the channel topic.

@khiga8
Copy link
Collaborator Author

khiga8 commented Apr 3, 2023

I'm going to do this in one PR since it is easier for me.

@khiga8 khiga8 closed this Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@accessibility-bot accessibility-bot Awaiting requested review from accessibility-bot accessibility-bot is a code owner automatically assigned from github/accessibility-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khiga8 @accessibility-bot