Only allow string literal as tag name values. #33

koddsson · 2021-10-08T14:03:31Z

This is to prevent the rule from blowing up if there's no value property on the first argument such as if the argument is an expression.

const tagName = 'my-cool-element'

window.customElements.define(tagName, class extends HTMLElement)

keithamus

👍 great!

koddsson added 2 commits October 8, 2021 14:49

Give up if tag name has no value

c340bab

Error on non-literal arguments for tag names

e8a3bab

koddsson requested a review from keithamus October 8, 2021 14:03

keithamus approved these changes Oct 8, 2021

View reviewed changes

koddsson merged commit 39f6d67 into main Oct 11, 2021

koddsson deleted the give-up-if-tag-name-doesnt-have-a-value branch October 11, 2021 12:22

Provide feedback