This repository was archived by the owner on Sep 18, 2023. It is now read-only.
Add option allowedSuperNames for extends-correct-class
#38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
extends-correct-class
extends-correct-classextends-correct-class
keithamus
approved these changes
Feb 8, 2022
lib/rules/extends-correct-class.js
Outdated
| allowedSuperNames = [builtInTagMap[extendsTag]] | ||
| } else { | ||
| allowedSuperNames = [...((context.options[0] || {}).allowedSuperNames || [])] | ||
| // Make sure to treat this like a set. |
There was a problem hiding this comment.
If we'd like to treat this like a Set, does it make sense to just make it a Set?
There was a problem hiding this comment.
I think changing it to a Set also works!
To stringify with the changes, would we need to convert back to an array?
Never mind tried this out, also works with an iterable! I made the change, thanks for the speedy reviews.
This works great! I'll pull down and update the unit tests. Co-authored-by: Keith Cirkel <keithamus@users.noreply.github.com>
koddsson
approved these changes
Feb 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32
Description
This adds an option
allowedSuperNamesto theextends-correct-classrule that an Autonomous custom element may extend. It is assumed that by using this option, any allowed super name must extendHTMLElementin its prototype chain.