Skip to content
This repository was archived by the owner on Sep 18, 2023. It is now read-only.

Limit no-customized-built-in-elements to built ins #39

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Limit no-customized-built-in-elements to built ins #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/rules/no-customized-built-in-elements.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
const s = require('../custom-selectors')
const {builtInTagMap} = require('../tag-names')

module.exports = {
meta: {
type: 'problem',
Expand All @@ -8,7 +10,11 @@ module.exports = {
create(context) {
return {
[s.HTMLElementClass](node) {
if (node.superClass && node.superClass.name !== 'HTMLElement') {
if (
node.superClass &&
node.superClass.name !== 'HTMLElement' &&
Object.values(builtInTagMap).includes(node.superClass.name)
) {
context.report(node, 'Avoid extending built-in elements')
}
}
Expand Down
3 changes: 2 additions & 1 deletion test/no-customized-built-in-elements.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ ruleTester.run('no-customized-built-in-elements', rule, {
{code: 'class SomeMap extends Map { }'},
{code: 'class FooBarElement { }'},
{code: 'class FooBarElement extends HTMLElement { }'},
{code: 'const FooBarElement = class extends HTMLElement { }'}
{code: 'const FooBarElement = class extends HTMLElement { }'},
{code: 'const FooBarElement = class extends HTMLRandomNotBuiltInElement { }'}
],
invalid: [
{
Expand Down