This repository was archived by the owner on Sep 18, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider these two code-snippets:
In both cases, the if statement has the type
LogicalExpression
, which we weren't checking for in our lint rule. Additionally, in the former snippet, thecustomElements.get
call is aUnaryExpression
and gets handled by our existing code. Still, the parent is just aLogicalExpression
in the second snippet. So we make sure to not register the element if its parent is aLogicalExpression
.