Skip to content
This repository was archived by the owner on Sep 18, 2023. It is now read-only.

Removal of conflicting rec #47

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Removal of conflicting rec #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/rules/no-dom-traversal-in-attributechangedcallback.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ document.body.innerHTML = '<foo-bar baz="bing"></foo-bar>'

Guarding against `null` properties, or returning early for `isConnected === false` is not good enough because there is high risk that attribute changes won't be properly propagated and state can fall out of sync. Guarding against these means adding duplicate code in other lifecycle callbacks such as `connectedCallback` to ensure this state does not fall out of sync. It is instead preferable to move such DOM traversals away from `attributeChangedCallback`, using one of the following:

- move traversals to `connectedCallback`
- dispatch events from `attributeChangedCallback`, binding event listeners on the element itself within `connectedCallback`
- defer DOM traversals to just-in-time lookup using methods or getters.

Expand Down